Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamescope: 3.14.2 -> 3.14.3 #303785

Merged
merged 1 commit into from
Apr 14, 2024
Merged

gamescope: 3.14.2 -> 3.14.3 #303785

merged 1 commit into from
Apr 14, 2024

Conversation

K900
Copy link
Contributor

@K900 K900 commented Apr 13, 2024

Description of changes

This has the native Wayland backend with HDR support.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@returntoreality
Copy link
Contributor

Result of nixpkgs-review pr 303785 run on x86_64-linux 1

4 packages built:
  • bottles
  • bottles-unwrapped
  • gamescope
  • gamescope-wsi
Also tested gamescope and it works

@VeilSilence
Copy link

VeilSilence commented Apr 14, 2024

Is capSysNice = true; working for you in 3.14.3?
Launching from terminal gamescope glxgears for example and it works correctly, but when i'm trying to launch any game on steam with this command line gamescope -w 2560 -h 1440 -f -r 240 --force-grab-cursor gamemoderun --mangoapp %command% i got this error: failed to inherit capabilities: Operation not permittedUploaded AppInterfaceStats to Steam
Also --mangoapp not showing nvidia related sensors. Normal mangohud working.

@K900
Copy link
Contributor Author

K900 commented Apr 14, 2024

This is a known issue that's unrelated to this PR.

@diniamo
Copy link
Contributor

diniamo commented Apr 14, 2024

Just to clarify, are both of the issues unrelated to the PR?

@K900
Copy link
Contributor Author

K900 commented Apr 14, 2024

Correct.

@@ -99,7 +101,7 @@ stdenv.mkDerivation (finalAttrs: {
glm
] ++ lib.optionals enableWsi [
vulkan-headers
] ++ lib.optionals enableExecutable [
] ++ lib.optionals enableExecutable (wlroots.buildInputs ++ [ # gamescope uses a custom wlroots branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting and simple solution

@K900 K900 merged commit 96ffa2e into NixOS:master Apr 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants