rPackages.FLAMES: fix build #303210
Merged
rPackages.FLAMES: fix build #303210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why package name is in uppercase? Shouldn't it be lowercase? What are the consequences of having it in lowercase? |
It's uppercase because that's how it's registered in CRAN. Renaming CRAN packages would lead to a lot of confusion and difficulty. |
|
@ofborg build rPackages.FLAMES |
|
Builds successfully on aarch-linux, lgtm |
b-rodrigues
approved these changes
Apr 12, 2024
superherointj
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added missing sysdeps and patched out code that tried to reduce library size by stripping symbols/
It fixes build, but the package doesn't function yet. it uses basilisk, which tries to install miniconda, but this won't run on nixos. basilisk should be patched/fixed to use another python env, if possible at all
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.