Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Check cherry-picks): gracefully fail when original commit hash cannot be identified #303192

Closed

Conversation

LeSuisse
Copy link
Contributor

Description of changes

Follow-up to this report: #172098 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@risicle
Copy link
Contributor

risicle commented Apr 10, 2024

Hmm.. I think we should probably try and avoid processing (and emitting any output) for any commits that don't look like cherry-picks, both for speed and clarity. The reason it was breaking is just because my recent method of using <<< "$(...)" for the iteration will emit an empty string when no matching commits are found.

@LeSuisse
Copy link
Contributor Author

Fine by me, it less likely to generate unwanted failures 👍 . Let's go for #303211

@LeSuisse LeSuisse closed this Apr 10, 2024
@LeSuisse LeSuisse deleted the ci-checks-cherry-picks-no-source branch April 10, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants