Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlv-app: 1.11 -> 1.14 #301792

Merged
merged 1 commit into from
Apr 14, 2024
Merged

mlv-app: 1.11 -> 1.14 #301792

merged 1 commit into from
Apr 14, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 5, 2024 •
edited
Loading

Description of changes

Update mlv-app: 1.11 -> 1.14

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from Kiwi April 5, 2024 10:43
@JohnRTitor
Copy link
Contributor Author

Reviewers: @Kiwi @h7x4
Should close #295309

@JohnRTitor
Copy link
Contributor Author

Result of nixpkgs-review pr 301792 run on x86_64-linux 1

1 package built:
  • mlv-app

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3775

@Artturin
Copy link
Member

Artturin commented Apr 14, 2024 •
edited
Loading

Launches

@Artturin Artturin merged commit 339b8d2 into NixOS:master Apr 14, 2024
31 checks passed
@JohnRTitor JohnRTitor deleted the mlv-app branch April 14, 2024 17:03
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Apr 14, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Awaiting requested review from Kiwi

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnRTitor @nixos-discourse @Artturin