Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logiops: make 0.2.3 default #293843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylechui
Copy link
Contributor

@kylechui kylechui commented Mar 6, 2024

The newest version of logiops has quite a few bugs, the issues would be quite hard to fix, and the package seems to have been unmaintained for the last 8 months. See:

PixlOne/logiops#409
#289701 (comment)

Description of changes

This change regresses #289701, and makes v0.2.3 the default version provided by pkgs.logiops.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave 0.3.3 renamed to logiops_0_3_3 & swap it with 0.2.3 so we don't get a third attempt at packaging this (^:

This will also be nice once the author returns, which they probably will as they have before: (Feb 2023)
email screenshot

The newest version of `logiops` has quite a few bugs, the issues would
be quite hard to fix, and the package seems to have been unmaintained
for the last 8 months. See:

PixlOne/logiops#409
NixOS#289701 (comment)
@ofborg ofborg bot requested a review from ckiee March 7, 2024 00:34
@ckiee ckiee changed the title logiops: remove version 0.3.3 logiops: make 0.2.3 default Mar 7, 2024
@ckiee
Copy link
Member

ckiee commented Mar 7, 2024

Cool. will review later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants