Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 10.7 Libm #273014

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Introduce 10.7 Libm #273014

wants to merge 4 commits into from

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Dec 8, 2023

Description of changes

No new versions of Libm have been released since macOS 10.7.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@toonn toonn changed the title Introduce 10.7 libm Introduce 10.7 Libm Dec 10, 2023
@reckenrode
Copy link
Contributor

The 10.13 SDK will need #262567, or it won’t be able to build a bunch of stuff (jq, Ruby, Guile, and probably others).

toonn added 4 commits May 31, 2024 15:41
The `applePackageMapping` function will allow us to keep expressions for
the newer releases separate from the originals where necessary, without
needing to change `generate-sdk-packages.sh`. If we ever want to support
multiple versions of source releases simultaneously we should consider
changing that to point to versioned subdirectories of all the packages.

Many of the source releases introduced here will need changes to the
expression to build successfully. These will be introduced one by one.
Releases with dependencies on other releases, e.g., libresolv depends on
Libinfo, mDNSResponder and configdHeaders, were getting those releases
from pkgs.darwin rather than pkgs.darwin."10.13.6". By making the scope
of callPackage overridable we can manipulate which packages are used to
supply dependencies.
No new versions of Libm have been released since macOS 10.7.
@toonn toonn marked this pull request as ready for review June 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants