Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jankyborders: init at 1.6.0 #268334

Merged
merged 1 commit into from
Mar 16, 2024
Merged

jankyborders: init at 1.6.0 #268334

merged 1 commit into from
Mar 16, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 18, 2023 •
edited
Loading

Description of changes

https://github.com/FelixKratz/JankyBorders

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FelixKratz
Copy link

I have not used nix before, but this error might be due to linking with an outdated version of SkyLight. The missing symbol was added in Ventura I think.

@khaneliman
Copy link
Contributor Author

khaneliman commented Nov 20, 2023 •
edited
Loading

I have not used nix before, but this error might be due to linking with an outdated version of SkyLight. The missing symbol was added in Ventura I think.

This would make sense... unfortunately the sdk version we're utilizing in nixpkgs looks like just 11.0. So this might be dependent on #229210 ?

@khaneliman khaneliman force-pushed the jankyborders branch 3 times, most recently from 1af82d7 to c181168 Compare March 15, 2024 13:46
@khaneliman khaneliman changed the title jankyborders: init at 1.2.5 jankyborders: init at 1.6.0 Mar 15, 2024
@khaneliman
Copy link
Contributor Author

@GrahamcOfBorg build jankyborders

@khaneliman khaneliman marked this pull request as ready for review March 15, 2024 14:31
@khaneliman
Copy link
Contributor Author

@GrahamcOfBorg build jankyborders

@khaneliman
Copy link
Contributor Author

@FelixKratz looks to be building now after that symbol change, thanks for letting me know. Using it in my personal config from nix derivation, already. :)

@khaneliman
Copy link
Contributor Author

Result of nixpkgs-review pr 268334 run on aarch64-darwin 1

1 package built:
  • jankyborders

@drupol drupol merged commit a99c3b4 into NixOS:master Mar 16, 2024
25 of 27 checks passed
@khaneliman khaneliman deleted the jankyborders branch March 16, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaneliman @FelixKratz @drupol