Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woodpecker: 1.0.3 -> 1.0.5 #266462

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Nov 9, 2023

Description of changes

https://github.com/woodpecker-ci/woodpecker/blob/v1.0.5/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ambroisie
Copy link
Contributor

The 2.0.0 update should be coming soon BTW.

@mweinelt
Copy link
Member

mweinelt commented Nov 9, 2023

The 2.0.0 update should be coming soon BTW.

That sounds like breaking changes. Too late for NixOS 23.11.

@mweinelt
Copy link
Member

mweinelt commented Nov 9, 2023

Please add meta.changelog and reference the changelog URL in the commit message.

https://github.com/woodpecker-ci/woodpecker/blob/v${version}/CHANGELOG.md

@ambroisie
Copy link
Contributor

That sounds like breaking changes. Too late for NixOS 23.11.

It is semver breaking, but only in the most minor ways (they're removing things that have been deprecated since 1.0.0).

Also, unless I'm mistaken targeting master for breaking changes is fine.

@mweinelt
Copy link
Member

mweinelt commented Nov 9, 2023

Also, unless I'm mistaken targeting master for breaking changes is fine.

We're in breaking changes freeze since 2023-10-30 until after the branch-off around 2023-11-20.

#258640

@ambroisie
Copy link
Contributor

Ah, I'd missed that it was already started, thank you 👍.

@adamcstephens
Copy link
Contributor Author

adamcstephens commented Nov 9, 2023

Please add meta.changelog

meta.changelog is already defined in common.nix...

https://github.com/NixOS/nixpkgs/pull/266462/files#diff-594f9dcad2ced6f3aafe753b211539c1b3c28d7156214957b874b86c72615fddR34

@MayNiklas
Copy link
Member

MayNiklas commented Nov 11, 2023

The 2.0.0 update should be coming soon BTW.

There is already a release candidate for 2.0.0 I wanted to play around with.
Unfortunately, I wasn't able to 'just update' the woodpecker package to 2.0.0 - it will require some small changes on the frontend package!

@Artturin Artturin merged commit 45c8340 into NixOS:master Nov 12, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants