formats.libconfig: fix unstable store path dependency in test #264581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
K900
reviewed
Oct 31, 2023
ckiee
force-pushed
the
libconfig-fix-unstable-store-paths
branch
from
689e2e4
to
849b643
Compare
|
So sorry about this 😥 |
Previously, this test would verify a writeText file with a constant content is at a precise store path, but this is not actually the case and the store path has changed maybe twice since the original "pkgs.formats: Add libconfig format generator" PR was started, the latest time being after it was merged. We now placehold the store path in expected.txt and substitute it just before we run the diff, alleviating the problem.
ckiee
force-pushed
the
libconfig-fix-unstable-store-paths
branch
from
849b643
to
faf4e7b
Compare
|
So, it turns out the original PR was just missing an Still, a FOD in a test is a bit scary since it gets cached in the Nix store and keyed by the |
13 tasks
|
@infinisil done, split into #264638 :) |
|
I only verified that the test builds for me, so that channels get unblocked. It sounds like some of you did actually check that the tests really do what they're meant to do. |
|
Mhm. We trade off a bit of coverage for not getting another problem with this bit of the test. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, this test would verify a writeText file with a constant content is at a precise store path, but this is not actually the case and the store path has changed maybe twice since the original PR was started (#246115), the latest time being after it was merged.
We now placehold the store path in expected.txt and substitute it just before we run the diff, alleviating the problem.
Fixes #246115 (comment), a
nixpkgs-unstableregression.cc @vcunat @h7x4
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)