Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libshout: fix build with clang 16 #262820

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

reckenrode
Copy link
Contributor

Description of changes

  • Upstream MR includes several missing headers that were resulting in implicit function declaration errors.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

* Upstream MR includes several missing headers that were resulting in
  implicit function declaration errors.
@reckenrode
Copy link
Contributor Author

reckenrode commented Oct 27, 2023

This is failing on staging-next: https://hydra.nixos.org/build/239449199. #263535

@reckenrode reckenrode changed the base branch from master to staging-next October 27, 2023 12:46
@reckenrode
Copy link
Contributor Author

Targeting staging-next due to the number of rebuilds.

@wegank wegank merged commit fd36865 into NixOS:staging-next Oct 27, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants