curl: drop Darwin-specific patches #260599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Darwin stdenv and CF no longer depend on libcurl, so the patches required to break the mutual recursion between CF and libcurl are no longer needed. Dropping them simplifies the curl derivation and restores support for NAT64.
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
Oct 13, 2023
Unblocks staging-next and restores NAT64 support on Darwin. Closes NixOS#260599
|
Superseded by #260599. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The Darwin stdenv and CF no longer depend on libcurl, so the patches required to break the mutual recursion between CF and libcurl are no longer needed. Dropping them simplifies the curl derivation and restores support for NAT64.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)