Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mjpegtools: fix build with clang 16 #259869

Merged
merged 1 commit into from
Oct 11, 2023
Merged

mjpegtools: fix build with clang 16 #259869

merged 1 commit into from
Oct 11, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Oct 8, 2023 •
edited
Loading

Description of changes

Clang 16 defaults to C++17, causing the build to fail because the following has been removed from C++17:

  • std::auto_ptr; and
  • The register type class specifier.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode reckenrode mentioned this pull request Oct 8, 2023
Closed
@ofborg ofborg bot requested a review from abbradar October 9, 2023 00:53
@eliasnaur
Copy link
Contributor

Clang 17

Did you mean clang 16? That's what the comment says.

@reckenrode
Copy link
Contributor Author

reckenrode commented Oct 10, 2023 •
edited
Loading

Clang 17

Did you mean clang 16? That's what the comment says.

That’s a typo. I’ll fix the commit message.

@reckenrode
mjpegtools: fix build with clang 16
9622ba4 
Clang 16 defaults to C++17, causing the build to fail because the
following has been removed from C++17:

* `std::auto_ptr`; and
* The `register` type class specifier.
toonn
toonn approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes building with Clang 16 on both Linux and Darwin.

@toonn toonn merged commit ee7c5f0 into NixOS:staging Oct 11, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toonn toonn toonn approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reckenrode @eliasnaur @toonn