Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiofile: fix build with clang 16 #259300

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

viraptor
Copy link
Contributor

@viraptor viraptor commented Oct 6, 2023

Description of changes

std::unary_function is removed in c++17
This breaks building with clang 16. (#234710)

Things done

Set the -std to a lower one.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue on x86_64-darwin. However, I can't reproduce the failure on x86_64-linux.
Any idea why that might be? I would assume Clang 16 on Linux still defaults to C++17?

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The lack of failure on x86_64-linux without these fixes is due to libstdc++ opting to implement those classes for ABI stability apparently.

@toonn toonn merged commit 114236d into NixOS:staging Oct 14, 2023
23 checks passed
@viraptor viraptor deleted the audiofile-clang branch October 14, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants