Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tachidesk-server: init at 0.7.0 #257733

Closed
wants to merge 5 commits into from

Conversation

RatCornu
Copy link
Contributor

@RatCornu RatCornu commented Sep 27, 2023

Description of changes

https://github.com/Suwayomi/Tachidesk-Server

A free and open source manga reader server that runs extensions built for Tachiyomi.

Tested the program with different configurations on an headless server.

Added a nixos module and a package called in the module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@h7x4
Copy link
Member

h7x4 commented Oct 16, 2023

I think you'll have to reorder your commits, so you add yourself to the maintainer list before initializing the package

@RatCornu
Copy link
Contributor Author

Indeed, I've just reordered them, thanks !

Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Just a bit of nits here and there.

I think it would be nice to have a small nixos test to verify that the module runs with a minimal config, but I'm not planning to block the PR if you don't wanna deal with that.

pkgs/by-name/ta/tachidesk-server/package.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
pkgs/by-name/ta/tachidesk-server/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ta/tachidesk-server/package.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/tachidesk-server.nix Outdated Show resolved Hide resolved
@RatCornu RatCornu force-pushed the tachidesk-server branch 8 times, most recently from 40506aa to 7f03833 Compare October 18, 2023 14:05
@RatCornu
Copy link
Contributor Author

RatCornu commented Jan 18, 2024

I'm sorry I think I did something I shouldn't have during a rebase... I try to fix this

@h7x4
Copy link
Member

h7x4 commented Jan 18, 2024

Please open a new PR :)

@h7x4 h7x4 closed this Jan 18, 2024
@NixOS NixOS locked as too heated and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants