-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tachidesk-server: init at 0.7.0 #257733
Conversation
7921aa1
to
c854279
Compare
4f220cf
to
fb71ab5
Compare
I think you'll have to reorder your commits, so you add yourself to the maintainer list before initializing the package |
fb71ab5
to
090627f
Compare
Indeed, I've just reordered them, thanks ! |
090627f
to
6838771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Just a bit of nits here and there.
I think it would be nice to have a small nixos test to verify that the module runs with a minimal config, but I'm not planning to block the PR if you don't wanna deal with that.
40506aa
to
7f03833
Compare
I'm sorry I think I did something I shouldn't have during a rebase... I try to fix this |
Please open a new PR :) |
Description of changes
https://github.com/Suwayomi/Tachidesk-Server
A free and open source manga reader server that runs extensions built for Tachiyomi.
Tested the program with different configurations on an headless server.
Added a nixos module and a package called in the module.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)