Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xaw3d: 1.6.3 -> 1.6.5 #253727

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Xaw3d: 1.6.3 -> 1.6.5 #253727

merged 1 commit into from
Oct 9, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Sep 6, 2023 •
edited
Loading

Description of changes

1.6.4 release announcement: https://lists.x.org/archives/xorg-announce/2022-August/003202.html
1.6.5 release announcement: https://lists.x.org/archives/xorg-announce/2023-May/003396.html

This update also fixes a build failure with clang 16.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode reckenrode mentioned this pull request Sep 6, 2023
Closed
toonn
toonn approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the build with Clang 16

Edit: Builds on Linux too.

@toonn toonn merged commit 1a9afd5 into NixOS:staging Oct 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toonn toonn toonn approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @toonn