Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlstarlet: fix build with clang 16 #246660

Merged
merged 1 commit into from
Aug 5, 2023
Merged

xmlstarlet: fix build with clang 16 #246660

merged 1 commit into from
Aug 5, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Aug 1, 2023 •
edited
Loading

Description of changes

Fixes an incompatible function pointer error when building with clang 16.

nixpkgs-review will have expected failures for qtwebengine until #245640 hits master.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
xmlstarlet: fix build with clang 16
62ddedb 
Fixes an incompatible function pointer error when building with clang 16.
@reckenrode reckenrode mentioned this pull request Aug 1, 2023
Closed
@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 246660 run on aarch64-darwin 1

6 packages marked as broken and skipped:
  • gpxsee-qt6
  • khoj
  • khoj.dist
  • path-of-building
  • qutebrowser-qt6
  • qutebrowser-qt6.dist
22 packages failed to build:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • aw-qt
  • aw-qt.dist
  • kemai
  • ladybird
  • mnemosyne
  • mnemosyne.dist
  • python310Packages.pyqt6-webengine
  • python310Packages.pyqt6-webengine.dev
  • python310Packages.pyqt6-webengine.dist
  • python311Packages.pyqt6-webengine
  • python311Packages.pyqt6-webengine.dev
  • python311Packages.pyqt6-webengine.dist
  • qt6.full
  • qt6.qtwebengine
  • qt6.qtwebengine.dev
  • retext
  • retext.dist
  • stellarium
121 packages built:
  • alice-tools-qt6
  • bambootracker-qt6
  • beamerpresenter
  • beamerpresenter-poppler
  • calcmysky
  • cutemaze
  • dolphin-emu
  • hydrus
  • hydrus.doc
  • libremines
  • maskromtool
  • nanovna-saver
  • nanovna-saver.dist
  • notes
  • pokefinder
  • python310Packages.pyqt6
  • python310Packages.pyqt6-charts
  • python310Packages.pyqt6-charts.dist
  • python310Packages.pyqt6.dev
  • python310Packages.pyqt6.dist
  • python310Packages.pyside6
  • python310Packages.shiboken6
  • python311Packages.pyqt6
  • python311Packages.pyqt6-charts
  • python311Packages.pyqt6-charts.dist
  • python311Packages.pyqt6.dev
  • python311Packages.pyqt6.dist
  • python311Packages.pyside6
  • python311Packages.shiboken6
  • qalculate-qt
  • qownnotes
  • qt6.qmake
  • qt6.qt3d
  • qt6.qt3d.dev
  • qt6.qt5compat
  • qt6.qt5compat.dev
  • qt6.qtbase
  • qt6.qtbase.dev
  • qt6.qtcharts
  • qt6.qtcharts.dev
  • qt6.qtconnectivity
  • qt6.qtconnectivity.dev
  • qt6.qtdatavis3d
  • qt6.qtdatavis3d.dev
  • qt6.qtdeclarative
  • qt6.qtdeclarative.dev
  • qt6.qtdoc
  • qt6.qtgrpc
  • qt6.qtgrpc.dev
  • qt6.qthttpserver
  • qt6.qthttpserver.dev
  • qt6.qtimageformats
  • qt6.qtimageformats.dev
  • qt6.qtlanguageserver
  • qt6.qtlanguageserver.dev
  • qt6.qtlocation
  • qt6.qtlocation.dev
  • qt6.qtlottie
  • qt6.qtlottie.dev
  • qt6.qtmqtt
  • qt6.qtmqtt.dev
  • qt6.qtmultimedia
  • qt6.qtmultimedia.dev
  • qt6.qtnetworkauth
  • qt6.qtnetworkauth.dev
  • qt6.qtpositioning
  • qt6.qtpositioning.dev
  • qt6.qtquick3d
  • qt6.qtquick3d.dev
  • qt6.qtquick3dphysics
  • qt6.qtquick3dphysics.dev
  • qt6.qtquickeffectmaker
  • qt6.qtquickeffectmaker.dev
  • qt6.qtquicktimeline
  • qt6.qtquicktimeline.dev
  • qt6.qtremoteobjects
  • qt6.qtremoteobjects.dev
  • qt6.qtscxml
  • qt6.qtscxml.dev
  • qt6.qtsensors
  • qt6.qtsensors.dev
  • qt6.qtserialbus
  • qt6.qtserialbus.dev
  • qt6.qtserialport
  • qt6.qtserialport.dev
  • qt6.qtshadertools
  • qt6.qtshadertools.dev
  • qt6.qtspeech
  • qt6.qtspeech.dev
  • qt6.qtsvg
  • qt6.qtsvg.dev
  • qt6.qttools
  • qt6.qttools.dev
  • qt6.qttranslations
  • qt6.qttranslations.dev
  • qt6.qtvirtualkeyboard
  • qt6.qtvirtualkeyboard.dev
  • qt6.qtwebchannel
  • qt6.qtwebchannel.dev
  • qt6.qtwebsockets
  • qt6.qtwebsockets.dev
  • qt6.qtwebview
  • qt6.qtwebview.dev
  • qt6Packages.kcoreaddons
  • qt6Packages.kcoreaddons.bin
  • qt6Packages.kcoreaddons.dev
  • qt6Packages.poppler
  • qt6Packages.poppler.dev
  • qt6Packages.qtkeychain
  • qt6Packages.qtpbfimageplugin
  • qt6Packages.quazip
  • qt6Packages.quazip.dev
  • qt6Packages.qxlsx
  • qtwirediff
  • smb3-foundry
  • syncplay
  • wireshark
  • wireshark.dev
  • xmlstarlet
  • zint
  • zint.dev

@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 246660 run on x86_64-darwin 1

48 packages marked as broken and skipped:
  • adwaita-qt6
  • adwaita-qt6.dev
  • calibre
  • gpxsee-qt6
  • gromacsCudaMpi
  • khoj
  • khoj.dist
  • librealsenseWithCuda
  • librealsenseWithCuda.dev
  • mnemosyne
  • mnemosyne.dist
  • olive-editor
  • ostinato
  • pcsx2
  • python310Packages.bentoml
  • python310Packages.bentoml.dist
  • python310Packages.jaxlibWithCuda
  • python310Packages.jaxlibWithCuda.dist
  • python310Packages.numbaWithCuda
  • python310Packages.numbaWithCuda.dist
  • python310Packages.pycuda
  • python310Packages.pycuda.dist
  • python310Packages.pynvml
  • python310Packages.pynvml.dist
  • python310Packages.pyrealsense2WithCuda
  • python310Packages.pyrealsense2WithCuda.dev
  • python310Packages.theanoWithCuda
  • python310Packages.theanoWithCuda.dist
  • python311Packages.bentoml
  • python311Packages.bentoml.dist
  • python311Packages.jaxlibWithCuda
  • python311Packages.jaxlibWithCuda.dist
  • python311Packages.pycuda
  • python311Packages.pycuda.dist
  • python311Packages.pynvml
  • python311Packages.pynvml.dist
  • python311Packages.pyrealsense2WithCuda
  • python311Packages.pyrealsense2WithCuda.dev
  • python311Packages.theanoWithCuda
  • python311Packages.theanoWithCuda.dist
  • qt6.qtwayland
  • qt6.qtwayland.dev
  • qt6Packages.qtwayland
  • qt6Packages.qtwayland.dev
  • qutebrowser-qt6
  • qutebrowser-qt6.dist
  • truecrack-cuda
  • xgboostWithCuda
18 packages failed to build:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • aw-qt
  • aw-qt.dist
  • kemai
  • python310Packages.pyqt6-webengine
  • python310Packages.pyqt6-webengine.dev
  • python310Packages.pyqt6-webengine.dist
  • python311Packages.pyqt6-webengine
  • python311Packages.pyqt6-webengine.dev
  • python311Packages.pyqt6-webengine.dist
  • qt6.qtwebengine (qt6Packages.qtwebengine)
  • qt6.qtwebengine.dev (qt6Packages.qtwebengine.dev)
  • retext
  • retext.dist
  • stellarium
115 packages built:
  • alice-tools-qt6
  • bambootracker-qt6
  • beamerpresenter (beamerpresenter-mupdf)
  • beamerpresenter-poppler
  • cutemaze
  • dolphin-emu
  • hydrus
  • hydrus.doc
  • ladybird
  • libremines
  • nanovna-saver
  • nanovna-saver.dist
  • notes
  • pokefinder
  • python310Packages.pyqt6
  • python310Packages.pyqt6-charts
  • python310Packages.pyqt6-charts.dist
  • python310Packages.pyqt6.dev
  • python310Packages.pyqt6.dist
  • python310Packages.pyside6
  • python310Packages.shiboken6
  • python311Packages.pyqt6
  • python311Packages.pyqt6-charts
  • python311Packages.pyqt6-charts.dist
  • python311Packages.pyqt6.dev
  • python311Packages.pyqt6.dist
  • python311Packages.pyside6
  • python311Packages.shiboken6
  • qalculate-qt
  • qownnotes
  • qt6.qt3d (qt6Packages.qt3d)
  • qt6.qt3d.dev (qt6Packages.qt3d.dev)
  • qt6.qt5compat (qt6Packages.qt5compat)
  • qt6.qt5compat.dev (qt6Packages.qt5compat.dev)
  • qt6.qtbase (qt6Packages.qtbase)
  • qt6.qtbase.dev (qt6Packages.qtbase.dev)
  • qt6.qtcharts (qt6Packages.qtcharts)
  • qt6.qtcharts.dev (qt6Packages.qtcharts.dev)
  • qt6.qtconnectivity (qt6Packages.qtconnectivity)
  • qt6.qtconnectivity.dev (qt6Packages.qtconnectivity.dev)
  • qt6.qtdatavis3d (qt6Packages.qtdatavis3d)
  • qt6.qtdatavis3d.dev (qt6Packages.qtdatavis3d.dev)
  • qt6.qtdeclarative (qt6Packages.qtdeclarative)
  • qt6.qtdeclarative.dev (qt6Packages.qtdeclarative.dev)
  • qt6.qtdoc (qt6Packages.qtdoc)
  • qt6.qtgrpc (qt6Packages.qtgrpc)
  • qt6.qtgrpc.dev (qt6Packages.qtgrpc.dev)
  • qt6.qthttpserver (qt6Packages.qthttpserver)
  • qt6.qthttpserver.dev (qt6Packages.qthttpserver.dev)
  • qt6.qtimageformats (qt6Packages.qtimageformats)
  • qt6.qtimageformats.dev (qt6Packages.qtimageformats.dev)
  • qt6.qtlanguageserver (qt6Packages.qtlanguageserver)
  • qt6.qtlanguageserver.dev (qt6Packages.qtlanguageserver.dev)
  • qt6.qtlocation (qt6Packages.qtlocation)
  • qt6.qtlocation.dev (qt6Packages.qtlocation.dev)
  • qt6.qtlottie (qt6Packages.qtlottie)
  • qt6.qtlottie.dev (qt6Packages.qtlottie.dev)
  • qt6.qtmqtt (qt6Packages.qtmqtt)
  • qt6.qtmqtt.dev (qt6Packages.qtmqtt.dev)
  • qt6.qtmultimedia (qt6Packages.qtmultimedia)
  • qt6.qtmultimedia.dev (qt6Packages.qtmultimedia.dev)
  • qt6.qtnetworkauth (qt6Packages.qtnetworkauth)
  • qt6.qtnetworkauth.dev (qt6Packages.qtnetworkauth.dev)
  • qt6.qtpositioning (qt6Packages.qtpositioning)
  • qt6.qtpositioning.dev (qt6Packages.qtpositioning.dev)
  • qt6.qtquick3d (qt6Packages.qtquick3d)
  • qt6.qtquick3d.dev (qt6Packages.qtquick3d.dev)
  • qt6.qtquick3dphysics (qt6Packages.qtquick3dphysics)
  • qt6.qtquick3dphysics.dev (qt6Packages.qtquick3dphysics.dev)
  • qt6.qtquickeffectmaker (qt6Packages.qtquickeffectmaker)
  • qt6.qtquickeffectmaker.dev (qt6Packages.qtquickeffectmaker.dev)
  • qt6.qtquicktimeline (qt6Packages.qtquicktimeline)
  • qt6.qtquicktimeline.dev (qt6Packages.qtquicktimeline.dev)
  • qt6.qtremoteobjects (qt6Packages.qtremoteobjects)
  • qt6.qtremoteobjects.dev (qt6Packages.qtremoteobjects.dev)
  • qt6.qtscxml (qt6Packages.qtscxml)
  • qt6.qtscxml.dev (qt6Packages.qtscxml.dev)
  • qt6.qtsensors (qt6Packages.qtsensors)
  • qt6.qtsensors.dev (qt6Packages.qtsensors.dev)
  • qt6.qtserialbus (qt6Packages.qtserialbus)
  • qt6.qtserialbus.dev (qt6Packages.qtserialbus.dev)
  • qt6.qtserialport (qt6Packages.qtserialport)
  • qt6.qtserialport.dev (qt6Packages.qtserialport.dev)
  • qt6.qtshadertools (qt6Packages.qtshadertools)
  • qt6.qtshadertools.dev (qt6Packages.qtshadertools.dev)
  • qt6.qtspeech (qt6Packages.qtspeech)
  • qt6.qtspeech.dev (qt6Packages.qtspeech.dev)
  • qt6.qtsvg (qt6Packages.qtsvg)
  • qt6.qtsvg.dev (qt6Packages.qtsvg.dev)
  • qt6.qttools (qt6Packages.qttools)
  • qt6.qttools.dev (qt6Packages.qttools.dev)
  • qt6.qttranslations (qt6Packages.qttranslations)
  • qt6.qttranslations.dev (qt6Packages.qttranslations.dev)
  • qt6.qtvirtualkeyboard (qt6Packages.qtvirtualkeyboard)
  • qt6.qtvirtualkeyboard.dev (qt6Packages.qtvirtualkeyboard.dev)
  • qt6.qtwebchannel (qt6Packages.qtwebchannel)
  • qt6.qtwebchannel.dev (qt6Packages.qtwebchannel.dev)
  • qt6.qtwebsockets (qt6Packages.qtwebsockets)
  • qt6.qtwebsockets.dev (qt6Packages.qtwebsockets.dev)
  • qt6.qtwebview (qt6Packages.qtwebview)
  • qt6.qtwebview.dev (qt6Packages.qtwebview.dev)
  • qt6Packages.kcoreaddons
  • qt6Packages.kcoreaddons.bin
  • qt6Packages.kcoreaddons.dev
  • qt6Packages.poppler
  • qt6Packages.poppler.dev
  • qt6Packages.qtkeychain
  • qt6Packages.qtpbfimageplugin
  • qt6Packages.quazip
  • qt6Packages.quazip.dev
  • smb3-foundry
  • syncplay
  • wireshark (wireshark-qt)
  • wireshark.dev (wireshark-qt.dev)
  • xmlstarlet

@wegank wegank merged commit 5faab29 into NixOS:master Aug 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @wegank