mpv: 0.35.1 → 0.36.0

[andersk]

Description of changes

Update the mpv video player from 0.35.1 to 0.36.0.

https://github.com/mpv-player/mpv/releases/tag/v0.36.0
mpv-player/mpv@v0.35.1...v0.36.0

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[AndersonTorres]

Ofborg complains:

meson.build:1713:9: ERROR: No host machine compiler for 'osdep/macosx_application.m'

ofborg

[ncfavier]

Program /private/tmp/nix-build-mpv-0.36.0.drv-0/source/TOOLS/macos-sdk-version.py skipped: feature swift-build disabled

https://github.com/mpv-player/mpv/blob/9e449cc685fd0635ebed906acda0446b43db2f59/meson.build#L1475-L1495

Maybe we need to enable swiftSupport on darwin, not just aarch64-darwin?

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2507

[AndersonTorres]

Fifteen days and a "hey I pinged you on Discourse"?

[andersk]

Maybe we need to enable swiftSupport on darwin, not just aarch64-darwin?

This was dealt with separately in #245452.

Fifteen days and a "hey I pinged you on Discourse"?

Can you clarify whether you think fifteen days is too much, too little, or something else? I’m still not entirely sure what the norms are here, but I was previously told that posting to Discourse is the only effective way to get the attention of reviewers who can actually commit things.

[AndersonTorres]

I said 15 days ago that ofborg was complaining about some miscompilation in Darwin (with a quote of the message, by the way), and I have no Darwin machine to test locally, so I have no way to know that it was already solved by another PR.

An at-ping saying "hey, this Darwin issue was dealt in #linkForTheSolvedPR, please look at this PR again" should be sufficient to me to look in the GitHub interface (indeed I am writing this on the smartphone now).

In that meantime, the commit fell into conflicting/unmergeable status. Again, since I was not pinged on this issue since fifteen days ago when I said that ofborg complained about a miscompilation in Darwin (a platform that I have no way to test locally, btw), I had no way to know the status of this.

Also, I am one of the meta.maintainers of this package (and I am not "nixpkgs-retired" yet).
You are free to at-ping me (or any other maintainer for that matter), even more given that I already commented on this.

The worse that could happen is "sorry, I have no Darwin machine to test locally; let's seek some Darwin user to help".

Although, what I have seen when this issue popped up was an unmergeable PR and a gap of fifteen days between the latest comment and a Discourse ping.

At least a fixup of the issues highlighted above (the miscompilation and mostly the merge conflict) before trying an at-ping and/or a Discourse ping would be polite - not after.

I understand Discourse is such a good channel to call for help, but do the basics first.

^{I'm on a hook for bad behavior I suppose, but I can't cloak my disappointment.}

[andersk]

To be clear, @ncfavier had already fixed the Darwin issue by pushing an extra commit fc3dbaacacb123b943fd8314b9e02c534772a866 onto this PR, 9 hours after your message. The same change was made independently by others in #245452, which conflicted with that extra commit. I wasn’t notified of #245452 or the conflict; when I became aware of it, I fixed the conflict by removing the extra commit.

We’re all just doing our best here—let’s assume good faith, learn what we can, and move on.

[fpletz]

Sorry, didn't notice this PR when I merged #245452 or else I would've also reviewed this PR.