Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.poetry-core: fix build with newer clang #234864

Merged
merged 1 commit into from
May 30, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Silence an integer conversion warning that newer clangs issue, causing the build to fail.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Silence an integer conversion warning that newer clangs issue, causing
the build to fail.
@wegank
Copy link
Member

wegank commented May 30, 2023

An equivalent patch is

  postPatch = ''
    sed -i '13s/NULL/0/' \
      tests/masonry/builders/fixtures/extended/extended/extended.c \
      tests/masonry/builders/fixtures/src_extended/src/extended/extended.c \
      tests/masonry/builders/fixtures/extended_with_no_setup/extended/extended.c
  '';

So indeed, only the tests are affected. We could also send a proper fix upstream.

@wegank wegank closed this May 30, 2023
@wegank wegank reopened this May 30, 2023
@wegank wegank merged commit b3fb622 into NixOS:staging May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants