Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext: 0.21 -> 0.21.1 #234714

Merged
merged 1 commit into from
May 29, 2023
Merged

gettext: 0.21 -> 0.21.1 #234714

merged 1 commit into from
May 29, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Unfortunately, there’s no release announcement for this release. From the NEWS

Version 0.21.1 - October 2022

  • Runtime behaviour:

    • On AIX, locale names with a script or with an uppercase language are now
      supported.
      For example, sr_Cyrl_RS.UTF-8 is treated like sr_RS.UTF-8@cyrillic, and
      EN_US.UTF-8 is treated like en_US.UTF-8.
  • The base Unicode standard is now updated to 14.0.0.

  • Portability:

    • Building on macOS 11/arm64 is now supported.
    • Building on Linux/powerpc64le with glibc ≥ 2.35 is now supported.

The vendored gnulib was also updated, which indirectly fixes a build failure with clang 16. The version in 0.20 fails to build because it attempts to assign an incompatible function pointer that should have but does not have __attribute__((noreturn)). On clang 16, this is an error by default.

Things done

This causes way too many rebuilds to run nixpkgs-review, but I was able to build successfully a Darwin stdenv.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Unfortunately, there’s no release announcement for this release. From
the [NEWS][1].

> Version 0.21.1 - October 2022
>
> * Runtime behaviour:
>   - On AIX, locale names with a script or with an uppercase language are now
>     supported.
>     For example, sr_Cyrl_RS.UTF-8 is treated like sr_RS.UTF-8@cyrillic, and
>     EN_US.UTF-8 is treated like en_US.UTF-8.
>
> * The base Unicode standard is now updated to 14.0.0.
>
> * Portability:
>   - Building on macOS 11/arm64 is now supported.
>   - Building on Linux/powerpc64le with glibc ≥ 2.35 is now supported.

The vendored gnulib was also updated, which indirectly fixes a build
failure with clang 16. The version in 0.20 fails to build because it
attempts to assign an incompatible function pointer that should have but
does not have `__attribute__((noreturn))`. On clang 16, this is an error
by default.

[1]: https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=blob_plain;f=NEWS;hb=8b38ee827251cadbb90cb6cb576ae98702566288
@flokli
Copy link
Contributor

flokli commented Jun 1, 2023

It looks like the sources did change another time, so currently staging fails to build:

error: hash mismatch in fixed-output derivation '/nix/store/2c90gp52cvdprpj314d86qii9qil4fkb-gettext-0.21.1.tar.gz.drv':
         specified: sha256-6MNlDh2M7odcTzVWQjgsHfgwWL1aEe6FVcDPJ21kbUU=
            got:    sha256-97ddKLyBBjjVpNWg633BaeMOQwv3nxwH+YUTOpmX3tA=

I opened #235398 to unbreak staging for now.

@RaitoBezarius not sure if this ended up in 23.05 too, just wanted to make sure it's on your radar as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants