Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinentry-mac: fix build with Darwin sandbox enabled #234111

Merged
merged 1 commit into from
May 27, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented May 26, 2023

Description of changes

pinentry-mac needs PlistBuddy to build and hardcodes the system one at /usr/libexec/PlistBuddy. I tried to replace it with the one from xcbuild, but that version didn’t like the arguments the pinentry-mac build process was trying to pass to it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode reckenrode force-pushed the pinentry-mac-darwin-sandbox branch from c0d6e66 to 7ca376e Compare May 26, 2023 16:41
@reckenrode reckenrode force-pushed the pinentry-mac-darwin-sandbox branch from 7ca376e to 8f84341 Compare May 26, 2023 16:43
@wegank
Copy link
Member

wegank commented May 27, 2023

@ofborg build pinentry_mac gnupg22 gnupg

@wegank wegank merged commit 9fdb5f9 into NixOS:master May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants