Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phantomsocks: init at unstable-2023-04-05 #224793

Merged
merged 1 commit into from
Apr 23, 2023
Merged

phantomsocks: init at unstable-2023-04-05 #224793

merged 1 commit into from
Apr 23, 2023

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Apr 5, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@oluceps oluceps requested a review from ocfox April 6, 2023 09:12
@ocfox
Copy link
Member

ocfox commented Apr 6, 2023

Result of nixpkgs-review pr 224793 run on x86_64-linux 1

1 package built:
  • phantomsocks

@oluceps oluceps requested a review from NickCao April 22, 2023 09:58
@oluceps oluceps requested a review from NickCao April 23, 2023 06:15
NickCao
NickCao reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly happy with the description as it contains little information, but looks like upstream do intend to do so.

pkgs/tools/networking/phantomsocks/default.nix Outdated Show resolved Hide resolved
@oluceps oluceps changed the title phantomsocks: init at 2023-03-16 phantomsocks: init at 2023-04-05 Apr 23, 2023
@oluceps oluceps changed the title phantomsocks: init at 2023-04-05 phantomsocks: init at unstable-2023-04-05 Apr 23, 2023
@oluceps
Copy link
Member Author

oluceps commented Apr 23, 2023

This website provides more details. Has extended to longDescription now.

@NickCao
Copy link
Member

NickCao commented Apr 23, 2023

Result of nixpkgs-review pr 224793 run on x86_64-linux 1

1 package built:
  • phantomsocks

@NickCao NickCao merged commit 108f25c into NixOS:master Apr 23, 2023
@oluceps oluceps deleted the add-phantomsocks branch April 23, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

@ocfox ocfox ocfox approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oluceps @ocfox @NickCao