teams-for-linux: 1.0.53 → 1.0.59, add updateScript #222440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyinstarlight
force-pushed
the
upd/teams-for-linux-1.0.54
branch
from
3eef1db
to
77c56e3
Compare
lilyinstarlight
changed the title
lilyinstarlight
force-pushed
the
upd/teams-for-linux-1.0.54
branch
from
77c56e3
to
c56fb30
Compare
lilyinstarlight
changed the title
|
Result of 1 package built:
|
Alizter
approved these changes
Mar 26, 2023
lilyinstarlight
force-pushed
the
upd/teams-for-linux-1.0.54
branch
from
c56fb30
to
88c6054
Compare
lilyinstarlight
changed the title
lilyinstarlight
force-pushed
the
upd/teams-for-linux-1.0.54
branch
from
88c6054
to
60c5fd1
Compare
lilyinstarlight
force-pushed
the
upd/teams-for-linux-1.0.54
branch
from
60c5fd1
to
2a2dfe5
Compare
lilyinstarlight
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2068 |
Comment on lines
+16
to
+18
| vendorhash() { | ||
| (nix --extra-experimental-features nix-command build --impure --argstr nixpkgs "$nixpkgs" --argstr attr "$1" --expr '{ nixpkgs, attr }: let pkgs = import nixpkgs {}; in with pkgs.lib; (getAttrFromPath (splitString "." attr) pkgs).overrideAttrs (attrs: { outputHash = fakeHash; })' --no-link 2>&1 >/dev/null | tail -n3 | grep -F got: | cut -d: -f2- | stripwhitespace) 2>/dev/null || true | ||
| } |
There was a problem hiding this comment.
We should get this into nix-update if not already done
There was a problem hiding this comment.
Yeah this one's a bit of a special one since it's not using any standard Yarn builder atm and we would have to just tell it that a package having .offlineCache means Yarn (which is a reasonably strong convention but isn't 100% consistent for packages like this since it's not a standard builder)
Once we have buildYarnPackage though (#210814) we'll add support for it and yarnDeps in nix-update
Comment on lines
+20
to
+29
| findpath() { | ||
| path="$(nix --extra-experimental-features nix-command eval --json --impure -f "$nixpkgs" "$1.meta.position" | jq -r . | cut -d: -f1)" | ||
| outpath="$(nix --extra-experimental-features nix-command eval --json --impure --expr "builtins.fetchGit \"$nixpkgs\"")" | ||
|
|
||
| if [ -n "$outpath" ]; then | ||
| path="${path/$(echo "$outpath" | jq -r .)/$nixpkgs}" | ||
| fi | ||
|
|
||
| echo "$path" | ||
| } |
There was a problem hiding this comment.
tbh this can just be hardcoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add update script (based on existing one I use for
sonic-pi, which is in a similar situation with a FOD that isn't directly supported by nix-update right now) and bump versionThe only changes in the 1.0.53 -> 1.0.56 bump is supporting a custom app title (which didn't come with release notes it seems...), a command line flag to disable the notification sound (notes), and several bug fixes (notes)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)