-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
androidenv: Fix avdmanager create avd #213871
Conversation
@numinit Hey Morgan, would you please review this one as well. Thanks! |
@ofborg build androidenv.test-suite.passthru.tests |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/using-allowunfree-to-run-tests-in-ofborg/25528/1 |
57d22cf
to
080fda7
Compare
To resolve the conflict, I rebased, then push force, this branch. However, locally
but github shows a commit, e70d685, that's not in my branch, locally! any idea? |
080fda7
to
a74976e
Compare
I can squash those 3 commits into one, if you prefer to, but other than that, it's ready to merge. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1838 |
ofborg failed with
which doesn't look like a problem in this PR! |
a74976e
to
3e04f2a
Compare
rebased again :D it's fun!! |
3e04f2a
to
5ac2d53
Compare
pkgs/development/mobile/androidenv/examples/shell-with-emulator.nix
Outdated
Show resolved
Hide resolved
pkgs/development/mobile/androidenv/examples/shell-with-emulator.nix
Outdated
Show resolved
Hide resolved
To do so, we gathered different system images with the same abiVersion in the same derivation.
androidenv: replace buildInputs with nativeBuildInputs
androidenv: set config.allowUnfree = true for integration tests androidenv: fix concerns in the PR
e6ecb9f
to
a05928d
Compare
Hey @Artturin , @SuperSandro2000 , @numinit ! I just squashed some commits, then rebased, and force pushed. let me know if there's any problem here. Thanks! |
Description of changes
After adding
cmdline-tools
, theavdmanager create avd
has the following problemwhere it cannot find the
system-images
. This PR fixes that problem, and also added example and test for it. Also there are some improvements inemulate-app.nix
.Nevertheless, this is a part of #208047
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes