Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gperftools: broaden platforms #212127

Merged
merged 1 commit into from
Jan 23, 2023
Merged

gperftools: broaden platforms #212127

merged 1 commit into from
Jan 23, 2023

Conversation

alyssais
Copy link
Member

Description of changes

Builds fine for NetBSD, will build for FreeBSD once #211230 is merged, and the README mentions some amount of Windows support.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Builds fine for NetBSD, will build for FreeBSD once
NixOS#211230 is merged, and the README
mentions some amount of Windows support.
@alyssais alyssais added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Jan 22, 2023
@figsoda figsoda merged commit a972ffd into NixOS:master Jan 23, 2023
@alyssais alyssais deleted the gperftools-bsd branch January 23, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants