Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.slack-bolt: init at 1.16.1 #208906

Closed
wants to merge 2 commits into from

Conversation

jpetrucciani
Copy link
Member

Description of changes

I would like to include slack-bolt in nixpkgs to be able to create Slack bots and other applications using Slack's Bolt framework! This PR also includes adding boddle as a checkInput.

Previous PR for boddle here: #188832

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

pkgs/development/python-modules/boddle/default.nix Outdated Show resolved Hide resolved
owner = "keredson";
repo = pname;

# upstream doesn't tag releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we get tags.

pkgs/development/python-modules/boddle/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/boddle/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/slack-bolt/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/slack-bolt/default.nix Outdated Show resolved Hide resolved
@jpetrucciani
Copy link
Member Author

@fabaff thanks for the thorough review! I've made all the requested changes, and added a comment noting your issue in the boddle github repo!

@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jan 25, 2023

This has switched checkInputs to nativeCheckInputs to satisfy the recent tree-wide change (#206742)!

@fabaff is the lack of boddle tags a blocker for this PR in general? or would this be mergeable without those?

@jpetrucciani
Copy link
Member Author

closing since #243593 was merged.

@jpetrucciani jpetrucciani deleted the add_slack-bolt branch July 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants