Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-xmpp-alerts: Fix build by removing unittestCheckHook argument #191631

Merged
merged 1 commit into from
Sep 18, 2022
Merged

prometheus-xmpp-alerts: Fix build by removing unittestCheckHook argument #191631

merged 1 commit into from
Sep 18, 2022

Conversation

e1mo
Copy link
Member

@e1mo e1mo commented Sep 17, 2022

In #185430 the unittestCheckHook argument was introduced, causing the derivation to fail building since the unittestCheckHook is not passed. However the original PR already used the unittestCheckHook from python3Packages.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@e1mo
prometheus-xmpp-alerts: Fix build by removing unittestCheckHook argument
cddc669 
In NixOS#185430 the `unittestCheckHook` argument was introduced, causing the
derivation to fail building since the `unittestCheckHook` is not passed.
However the original PR already used the `unittestCheckHook` from
`python3Packages`.
@ofborg ofborg bot requested a review from fpletz September 17, 2022 10:02
fpletz
fpletz approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpletz fpletz merged commit a755079 into NixOS:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e1mo @fpletz