git-town: 7.7.0 -> 7.8.0 #185620
git-town: 7.7.0 -> 7.8.0 #185620
Conversation
Plus a patch to fix the build using Go 1.18.
|
Result of 1 package built:
|
|
Hi @allonsy, do you have time to take a look? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| patches = [ | ||
| # Fix "go vet" when building using Go 1.18. | ||
| (fetchpatch { | ||
| name = "fix-go-vet-in-go-1.18.patch"; | ||
| url = "https://github.com/git-town/git-town/commit/23eb0aca7b28c6a0afc21db553aa0e35d35891aa.patch"; | ||
| sha256 = "sha256-EyfhKVrQxRJNrYqaZI04dJogaXs1J+bbOIu7p8g2Clc="; | ||
| }) | ||
| ]; |
There was a problem hiding this comment.
This shouldn't matter. Are we running go vet as part of the build process?
There was a problem hiding this comment.
It appears that go vet or some portion of it runs automatically as part of go test.
There was a problem hiding this comment.
This should be disabled, we never want to run linters when building.
There was a problem hiding this comment.
I personally don't agree, unless the linter in question is purely focused on style enforcement. Even then, I would only diverge from upstream and disable it if it is causing other problems.
If this is a policy within nixpkgs, I don't mind following it, however.
There was a problem hiding this comment.
Even then, I would only diverge from upstream and disable it if it is causing other problems.
If it is causing problems it is already extra maintenance burden we could have avoided.
At least for python packages we enforce disabling linters and I think we should follow that in other places, too.
There was a problem hiding this comment.
We are optimizing for different things. Your opinion is legitimate too, no hard feelings. I'm currently not interested in pursuing disabling linting for Go projects. If it's a blocker, I'll close this PR.
There was a problem hiding this comment.
There was no reason to close this PR and delete the branch without even waiting for a response as soon as someone has a different opinion.
This shouldn't matter. Are we running go vet as part of the build process?
go test runs some go vet checks. If you are of the opinion that it would be better to disable them, it can be enforced in buildGoModule/buildGoPackage with -vet=off. I see no point in disabling them for only some individual packages.
Having this patch is perfectly fine, it's like any other upstream patch that we fetch while waiting for the next release.
There was a problem hiding this comment.
I restored the branch and reopened the PR. I can keep it open for discussion.
There was a problem hiding this comment.
Can we merge this PR? I think the discussion about what should and should not be run when running go test is out of scope here.
There was a problem hiding this comment.
go testruns somego vetchecks. If you are of the opinion that it would be better to disable them, it can be enforced inbuildGoModule/buildGoPackagewith-vet=off. I see no point in disabling them for only some individual packages.
Thanks, creating a PR to staging right now to fix similar issues in the future.
Plus a patch to fix the build using Go 1.18. Fixes #185096.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes