Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mopidy: fix pygobject issues for dependent packages #184015

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

lilyinstarlight
Copy link
Member

Description of changes

This PR fixes issues for dependent packages of mopidy, like mopidy-local, which started failing due to pygobject issues related to gobject-introspection not getting propagated as both a buildInput and a nativeBuildInput (see hydra build 185467300). Specifically, this adds gobject-introspection to propagatedNativeBuildInputs for the mopidy package

I'm not entirely certain what changed 2 days ago to cause it to start failing now (probably something in the last staging-next iteration?), but I do know Python packages are built with strictDeps = true by default and gobject-introspection needs to be a buildInput and a nativeBuildInput when strict deps are on (see #56943)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
nixpkgs-review

Result of nixpkgs-review run on x86_64-linux 1

19 packages built:
  • mopidy
  • mopidy-bandcamp
  • mopidy-iris
  • mopidy-jellyfin
  • mopidy-local
  • mopidy-moped
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-muse
  • mopidy-musicbox-webclient
  • mopidy-podcast
  • mopidy-scrobbler
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-subidy
  • mopidy-tunein
  • mopidy-youtube
  • mopidy-ytmusic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants