Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: add overrideable withLibunwind #170850

Closed
wants to merge 1 commit into from
Closed

llvmPackages: add overrideable withLibunwind #170850

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Apr 29, 2022

Description of changes

This makes it possible to disable bundling libunwind with Clang for out-of-tree platforms.

This shouldn't effect the current evaluation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ehmry ehmry marked this pull request as ready for review April 29, 2022 05:16
@ehmry ehmry added the 6.topic: exotic Exotic hardware or software platform label Apr 29, 2022
@ehmry ehmry requested a review from Ericson2314 April 29, 2022 15:37
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@rrbutani rrbutani mentioned this pull request Nov 14, 2022
Merged
92 tasks
@RaitoBezarius
Copy link
Member

Can we help get this merged? cc @lovesegfault

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 22, 2022
@github-actions github-actions bot added 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nim Nim programing language 6.topic: nixos labels Dec 22, 2022
@github-actions github-actions bot removed 6.topic: stdenv Standard environment 6.topic: rust 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: changelog 8.has: module (update) 6.topic: printing labels Dec 22, 2022
@ehmry
Copy link
Contributor Author

ehmry commented Dec 22, 2022 •
edited
Loading

Sorry about the mass-ping, I rebased against staging and pushed when the PR was based on master.

@ehmry
llvmPackages: add overrideable withLibunwind
319626a 
This makes it possible to disable bundling libunwind with Clang
for out-of-tree platforms.
@winterqt
Copy link
Member

Please reopen this -- the mass ping results in people receiving notifications anyways.

@winterqt winterqt closed this Dec 22, 2022
@NixOS NixOS locked and limited conversation to collaborators Dec 22, 2022
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
6.topic: exotic Exotic hardware or software platform 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehmry @RaitoBezarius @winterqt @rrbutani