Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: disable docs if cross compiling #170826

Closed
wants to merge 1 commit into from
Closed

harfbuzz: disable docs if cross compiling #170826

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2022 •
edited by ghost
Loading

Description of changes

This disables the gtk-doc builds when cross-compiling harfbuzz.

I needed this PR in order to build #148618.

Things done
  • Built on platform(s)
    • x86_64-linux (cross to aarch64-multiplatform)
    • powerpc64le-linux (cross to aarch64-multiplatform)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Apr 28, 2022
Merged
9 tasks
@ghost ghost marked this pull request as ready for review April 28, 2022 23:01
@ghost ghost changed the base branch from master to staging April 28, 2022 23:03
@ofborg ofborg bot requested a review from edolstra April 28, 2022 23:10
@ghost
Copy link
Author

ghost commented Apr 29, 2022

@ofborg eval

@ghost
Copy link
Author

ghost commented Apr 29, 2022

Closed because this appears unnecessary; see: #148618 (comment)

Still not sure why builds fail for me without this, but it must be a local issue.

@ghost ghost closed this Apr 29, 2022
@Mindavi
Copy link
Contributor

Mindavi commented Apr 29, 2022

FYI, probably this: #168753

@ghost
Copy link
Author

ghost commented Apr 29, 2022

FYI, probably this: #168753

Yep, that was it. Thanks!

@ghost ghost deleted the harfbuzz-disable-docs-if-crosscompiling branch January 23, 2024 06:45
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mindavi