Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.12.1 -> 0.12.2 #168330

Merged
merged 1 commit into from
Apr 13, 2022
Merged

ipfs: 0.12.1 -> 0.12.2 #168330

merged 1 commit into from
Apr 13, 2022

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Apr 11, 2022

Description of changes

https://github.com/ipfs/go-ipfs/releases/tag/v0.12.2
"This patch release fixes a security issue wherein traversing some malformed DAGs can cause the node to panic."

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Luflosi Luflosi added 1.severity: security 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. labels Apr 11, 2022
@ofborg ofborg bot requested review from fpletz and kalbasit April 11, 2022 21:27
@Luflosi
Copy link
Contributor Author

Luflosi commented Apr 12, 2022

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Apr 12, 2022
@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 12, 2022

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from asymmetric April 12, 2022 07:01
fabianhjr
fabianhjr approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works on staging-next

@SuperSandro2000 SuperSandro2000 merged commit e3e7e78 into NixOS:master Apr 13, 2022
@Luflosi Luflosi deleted the update/ipfs branch April 13, 2022 10:51
@Luflosi
Copy link
Contributor Author

Luflosi commented Apr 13, 2022

I'll need to backport this. A patch release was made for 0.11.x.

@Luflosi Luflosi mentioned this pull request Apr 15, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@kalbasit kalbasit Awaiting requested review from kalbasit

@asymmetric asymmetric Awaiting requested review from asymmetric

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
1.severity: security 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luflosi @fabianhjr @SuperSandro2000