nixos/logiops: init #167388
Closed
nixos/logiops: init #167388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This was referenced Jul 27, 2022
Closed
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1036 |
|
For some reason my Emacs is executing nixfmt instead of nixpkgs-fmt. Weird. |
|
cc @Ma27 @lheckemann if either of you feel like reviewing |
anund
reviewed
Jul 29, 2022
anund
approved these changes
Jul 29, 2022
anund
reviewed
Jul 30, 2022
anund
suggested changes
Jul 30, 2022
ckiee
force-pushed
the
logiops-nixos
branch
2 times, most recently
from
4c054ac
to
82459de
Compare
anund
approved these changes
Jul 31, 2022
|
Oops. Put the new libconfig changes in the wrong commit. Edit: That was perhaps my most ambitious git-fu so far, edited it all in place with a rebase, reset and stash :P |
ckiee
added a commit
to ckiee/logiops
that referenced
this pull request
Dec 10, 2022
NixOS will soon have a runtime test for logiops which uses an invalid configuration as a baseline, expecting it to fail. Silent errors are not nice for users; systemd does not inform users of stderr messages in nominally running services. NixOS/nixpkgs#167388
ckiee
added a commit
to ckiee/logiops
that referenced
this pull request
Dec 10, 2022
NixOS will soon have a runtime test for logiops which uses an invalid configuration as a baseline, expecting it to fail. Silent errors are not nice for users; systemd does not inform users of stderr messages in nominally running services. NixOS/nixpkgs#167388
13 tasks
ckiee
added a commit
to ckiee/logiops
that referenced
this pull request
Jan 2, 2023
NixOS will soon have a runtime test for logiops which uses an invalid configuration as a baseline, expecting it to fail. Silent errors are not nice for users; systemd does not inform users of stderr messages in nominally running services. NixOS/nixpkgs#167388
12 tasks
Co-authored-by: ckie <25263210+ckiee@users.noreply.github.com> Signed-off-by: h7x4 <h7x4@nani.wtf>
Co-authored-by: ckie <25263210+ckiee@users.noreply.github.com> Signed-off-by: h7x4 <h7x4@nani.wtf>
There's no negative test due to runner limitations. I tried to hack on the runner for a bit but it got out of scope and I'm not interested in learning more Python. My 'fork' of nixpkgs has a logiops-nixos-xtra branch for anyone interested in poking the testing more.
|
rebased on everything and attempted to bump logiops but it is very broken (PixlOne/logiops#409, among other possible issues) so that work is in a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a new NixOS module for logiops which you can read more about in #165936.
It depends on #208747 / #246115 (the
libconfigserializer) being merged first and is in draft until that.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes