Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unigine-superposition: init at 1.1 #163820

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Conversation

barinov274
Copy link
Contributor

@barinov274 barinov274 commented Mar 12, 2022

I want to add The Unigine Superposition GPU benchmarking tool. People will be able to install this benchmarking tool on nixos and benchmark their GPU.

  • Built on platform(s)
    • x86_64-linux

@barinov274 barinov274 force-pushed the superposition branch 2 times, most recently from 1c2afd8 to 6d00cb6 Compare March 12, 2022 11:33
@barinov274 barinov274 changed the title Superposition: init at 1.1 Unigine-Superposition: init at 1.1 Mar 12, 2022
@barinov274 barinov274 closed this Mar 12, 2022
@barinov274 barinov274 reopened this Mar 18, 2022
@barinov274 barinov274 force-pushed the superposition branch 4 times, most recently from b36cbf0 to ed03f88 Compare March 18, 2022 06:35
@barinov274
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Mar 20, 2022
@marvin-mk2
Copy link

marvin-mk2 bot commented Mar 20, 2022

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please format with nixpkgs-fmt.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
Comment on lines 148 to 151
for RES in 16 24 32 48 64 128 256
do
mkdir -p $out/share/icons/hicolor/"$RES"x"$RES"/apps
cp $INSTALL_DIR/icons/superposition_icon_$RES.png $out/share/icons/hicolor/"$RES"x"$RES"/apps/Superposition.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for RES in 16 24 32 48 64 128 256
do
mkdir -p $out/share/icons/hicolor/"$RES"x"$RES"/apps
cp $INSTALL_DIR/icons/superposition_icon_$RES.png $out/share/icons/hicolor/"$RES"x"$RES"/apps/Superposition.png
for RES in 16 24 32 48 64 128 256; do
mkdir -p $out/share/icons/hicolor/"$RES"x"$RES"/apps
cp $INSTALL_DIR/icons/superposition_icon_$RES.png $out/share/icons/hicolor/"$RES"x"$RES"/apps/Superposition.png

Comment on lines 135 to 144
# create .desktop file
echo "[Desktop Entry]" > $DESKTOP
echo "Type=Application" >> $DESKTOP
echo "Exec=$EXEC" >> $DESKTOP
echo "Path=$INSTALL_DIR/bin" >> $DESKTOP
echo "Name=Superposition Benchmark" >> $DESKTOP
echo "GenericName=A GPU Stress test tool from the UNIGINE" >> $DESKTOP
echo "Icon=Superposition" >> $DESKTOP
echo "Terminal=false" >> $DESKTOP
echo "Categories=Launcher;Benchmark;" >> $DESKTOP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use createDesktopItem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe makeDesktopItem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both actually.

@SuperSandro2000 SuperSandro2000 changed the title Unigine-Superposition: init at 1.1 unigine-superposition: init at 1.1 Mar 26, 2022
@SuperSandro2000 SuperSandro2000 merged commit cc7594a into NixOS:master Mar 26, 2022
@barinov274 barinov274 deleted the superposition branch March 26, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants