Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: add mips64 support #161165

Merged
merged 1 commit into from Mar 18, 2022
Merged

go: add mips64 support #161165

merged 1 commit into from Mar 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2022

This PR translates nix's system name for mips64el into golang's system names, so golang can be built targeting mips64el.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from kalbasit, Mic92 and zowoq as code owners February 21, 2022 05:35
zowoq
zowoq reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be go: add mips64 support

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes

pkgs/development/compilers/go/1.16.nix Show resolved Hide resolved
pkgs/development/compilers/go/binary.nix Outdated Show resolved Hide resolved
@zowoq zowoq changed the title mips64: golang support go: add mips64 support Feb 21, 2022
@zowoq
Copy link
Contributor

zowoq commented Feb 21, 2022

Commit message is still wrong.

@ghost
Copy link
Author

ghost commented Feb 21, 2022

Commit message is still wrong.

sorry, missed that. fixed now.

@zowoq
Copy link
Contributor

zowoq commented Feb 21, 2022

Does this depend on some of your other PRs to work?

@ghost
Copy link
Author

ghost commented Feb 21, 2022

No.

It isn't terribly useful without the rest of the support for mips64. However unlike all the other patches in the series this one can be merged ahead of the one that creates stuff like stdenv.isMips64 without breaking evaluation.

@ghost
Copy link
Author

ghost commented Feb 21, 2022

If you're curious, #161158 is the blocker. All the other mips64-related PRs except this one need to have #161158 merged first.

zowoq
zowoq requested changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until it works and is useful before merging so we aren't adding cruft.

@zowoq zowoq marked this pull request as draft February 21, 2022 09:13
@ghost ghost mentioned this pull request Feb 21, 2022
Merged
13 tasks
@zowoq zowoq mentioned this pull request Mar 1, 2022
Merged
14 tasks
@zowoq
Copy link
Contributor

zowoq commented Mar 17, 2022

@ofborg eval

@zowoq zowoq marked this pull request as ready for review March 17, 2022 21:51
@zowoq zowoq merged commit 55dae42 into NixOS:master Mar 18, 2022
@ghost ghost deleted the mips64-golang branch March 18, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zowoq