automatically add dependencies for vim plugins with a *.rockspec #160484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto
changed the title
This was referenced Mar 29, 2022
plan is to check for rockspec in store path, if yes, call luarocks2nix to get dependencies TODO need to fix luarocks-nix to work with local rockspecs luarocks-nix: bumped version cleanup ./pkgs/misc/vim-plugins/update.py --proc=10 --debug DEBUG --input-names ./pkgs/misc/vim-plugins/lua-plugin-names TODO run luarocks on store path instead 1 plugins were checked Checking for rockspec TOTO Found a rockspec ! /nix/store/a1ph5kd6gjzgy8vvpvzbnlaha9i4khvd-4a2d30f5fb77750c7a42be9bb58a9cc2c6c7f31d.tar.gz/gitsigns.nvim-scm-1.rockspec ran cmd: ['luarocks', 'nix', 'gitsigns.nvim'] can't find suitable rock gitsigns.nvim adding file wip
pkgs/applications/editors/vim/plugins/update.py --github-token=$GITHUB_TOKEN --input-names pkgs/applications/editors/vim/plugins/lua-plugin-names
teto
force-pushed
the
lua-plugins-autodeps
branch
from
90a5eac
to
3e27c94
Compare
|
this was not upstreamable. Much better approach at #178180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Thee are many neovim plugins that are written in lua, compared to vimscript, it favors using external dependencies (well mostly plenary or nvim-treesitter for now).
This is an attempt to leverage *.rockspec files in these vim plugins to autodeduce dependencies, this updates the vim update plugin so that:
1/ it looks for a rockspec in the source of the plugin
2/ if it detects one, it generates the lua derivation via luarocks2nix
3/ it generates the vim plugin derivation as usual but inherits buildInputs/meta from the lua derivation.
Right now, I've separated the lua plugins from the traditional system to ease updates. One question is if we should instead move these plugins to the luaPackages to maintainers/scripts/luarocks-packages.csv
I use this command to update the lua-generated.nix
NB: there is some effort to define a (neo)vim plugin format https://github.com/nvim-lua/nvim-package-specification . For now I've added rockspecs to several plugins not sure how it's going to evolve.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes