Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xflux-gui: init at 1.1.1 #15610

Merged
merged 1 commit into from
May 24, 2016
Merged

xflux-gui: init at 1.1.1 #15610

merged 1 commit into from
May 24, 2016

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented May 22, 2016 •
edited
Loading

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sheenobu
Copy link
Contributor Author

xflux itself is proprietary but xflux-gui is not. However, xflux-gui does ship its own version of the xflux binary, which I discard. Not sure if that means we have to mark this as unfree or not.

joachifm
joachifm reviewed May 22, 2016
View reviewed changes
pkgs/tools/misc/xflux/gui.nix
@@ -0,0 +1,42 @@
{ stdenv, pkgs, fetchFromGitHub, pythonPackages }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass in specific packages rather than the entire package set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took care of this. Thank you.

@joachifm
Copy link
Contributor

The GUI output will end up with a reference to the unfree xflux, thus it would be illegal to redistribute the resulting closure (assuming it's illegal to redistribute xflux itself). Is it feasible to allow the GUI to resolve the xflux command from PATH instead?

@sheenobu
Copy link
Contributor Author

sheenobu commented May 23, 2016 •
edited
Loading

@joachifm Good point, thanks.

The github repo for xflux-gui contains a copy of the xflux binary (itself non-free) and while I'm not using it, does that mean the entire github repo is non-free and shouldn't be cached by the nixos cache? I think I might have to mark the whole thing as 'nonfree' unfree. Thoughts?

@joachifm
Copy link
Contributor

That's unfortunate, and a little odd. Perhaps the binaries can be redistributed? The only thing I could find is the EULA, which clearly states that redistribution of f.lux is prohibited, but I'm not sure how that meshes with embedding binaries in a so-called open source repo on github ... Maybe ask the xflux-gui devs what they think?

I'd mark all of it unfree for now, just to be safe.

@sheenobu
Copy link
Contributor Author

I marked it all as unfree for now, so it should be ready to merge. I'll ask the xflux-gui devs and may go into IRC to ask about the philosophical issues of a free program calling out to a non-free one.

@joachifm joachifm merged commit a21df56 into NixOS:master May 24, 2016
@joachifm
Copy link
Contributor

Thanks

@sheenobu sheenobu deleted the xflux-gui branch October 10, 2016 03:37
andir added a commit to andir/nixpkgs that referenced this pull request Feb 9, 2018
@andir
linuxPackages.virtualbox: 5.1.26 -> 5.1.32
13c7daa 
Update to latest stable version from the 5.1 branch. Also fixes
compilation of the host driver on 4.15.

Changelog:

 * GUI: mouse events did not reach host windows behind the transparent VM window (Mac OS X hosts only; bug NixOS#16246)
 * Audio: fixed accidental crashes when using the AC'97 sound emulation (bug NixOS#16959)
 * Audio: fixed crash when default input or output devices have changed (bugs NixOS#16968, NixOS#16969, NixOS#17004)
 * Audio: fixed recording when using the ALSA backend
 * Audio: fixed handle leak when using the OSS backend
 * E1000: fixed a crash related to VLAN traffic over internal network (5.1.26 regression; bug NixOS#16960)
 * NAT: apply --natbindip1 to TCP connections (bug NixOS#16478)
 * OVF: when importing an appliance with XHCI controller, don't add an OHCI controller.
 * Mac OS X hosts: fixed a GUI crash if Spotlight is used from file dialogs (5.1.20 regression; bugs NixOS#16935, NixOS#16953)
 * Linux hosts: fixed creating fixed sized VDI images (bug NixOS#17010)
 * Linux hosts / guests: fixes for Linux 4.4 of openSUSE Leap 42.3 (bug NixOS#16966)
 * Bridged networking: align outgoing packet at word boundary, preventing Windows host crash in MsLbfoProvider.
 * Linux Additions: kernel drm driver support for custom EL7 Linux 3.10 kernel
 * Solaris Additions: hide an informational message on the bootup console
 * GUI: translation updates
 * GUI: Fixed double mouse cursor when using mouse integration without Guest Additions, actually a Qt 5.6 bug fixed with QT 5.6.3 (Mac OS X hosts only; bug NixOS#15610)
 * Solaris hosts: allow increasing MTU size for host-only adapter to 9706 bytes to support jumbo frames
 * Linux hosts: glibc 2.26 compile fix
 * Windows Additions: 3D related crash fix (bugs NixOS#17082, NixOS#17092)
 * GUI: fixed occasional screen corruption when host screen resolution is changed
 * User interface: increase proposed disk size when creating new VMs for Windows 7 and newer
 * Serial: fixed broken communication with certain devices on Linux hosts
 * VMM: Fixed problems using 256MB VRAM in raw-mode VMs
 * Audio: added HDA support for more exotic guests (e.g. Haiku)
 * Audio: fixed playback with ALSA backend (5.1.28 regression)
 * USB/OHCI: fixed a problem where OHCI emulation might sporadically drop data transfers
 * Windows hosts: VirtualBoxManager in the Python API no longer calls CoUninitialize when destroyed
 * Linux hosts: fixed VBoxNetFlt kernel module compilation failure with Linux kernel 4.14
 * Linux guests: fixed kernel module compilation and other problems with Linux kernel 4.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheenobu @joachifm