plasma5: load kwayland-integration plugin #139537
Conversation
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
| @@ -10,11 +10,5 @@ mkDerivation { | |||
| nativeBuildInputs = [ extra-cmake-modules ]; | |||
| buildInputs = [ libpthreadstubs libXdmcp qttools qtx11extras ]; | |||
| propagatedBuildInputs = [ qtbase ]; | |||
| patches = [ | |||
| ./0001-platform-plugins-path.patch | |||
There was a problem hiding this comment.
We need to load kwayland-integration as kwindowmanager plugin, but kwayland-integration depends on kwindowmanager
I see no way here to make it pure
There was a problem hiding this comment.
Might be possible by finding out what parts of kwindowmanager it depends on exactly and splitting that into a separate output. Or maybe it would be possible to set something up with env variables in the NixOS module?
There was a problem hiding this comment.
Might be possible by finding out what parts of
kwindowmanagerit depends on exactly and splitting that into a separate output
It is pretty much monolithic
Or maybe it would be possible to set something up with env variables in the NixOS module?
Well, it is possible to introduce new env variable in plasma5 nixos module, but this doesn't solve impurity, as environment needs to be propagated :D
There was a problem hiding this comment.
Tentatively approving based on outcomes. I don't have the mental model to grok the whole Qt5 and Plasma infra in Nixpkgs to know for sure whether this would or not cause issues with "impurity".
Though about Qt plugin impurities and environment, the ship sailed long ago I think.
Unfortunately true. |
Motivation for this change
Fixes: #118650
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)