-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plasma5: 5.21.5 -> 5.22 #127389
plasma5: 5.21.5 -> 5.22 #127389
Conversation
Result of 34 packages failed to build:
997 packages skipped due to time constraints:
51 packages built successfully:
2 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 42 packages failed to build:
928 packages skipped due to time constraints:
64 packages built successfully:
3 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
Plasma |
Is KSysGuard completely gone from upstream? If not I'd prefer to keep the package for now and just mark it as deprecated with a note pointing to the new system monitor package so people who for one reason or another insist on still using it can do so for the time being. |
I'm running this PR now with bump to plasma 5.22.1. So far, an issue I'm seeing is that neither the new System Monitor, nor the previous monitoring widgets I had, can show any meters for CPU, memory, etc... It seems they still depend on maybe some kind of |
|
Yes, I know, but since |
Seems like those widgets depends on new system-monitor app, and i didn't enabled it instead of ksysguard |
I have SystemMonitor itself installed explicity ( |
Have you installed it as |
|
This comment has been minimized.
This comment has been minimized.
I think the issue is that plasma has a new package: |
This comment has been minimized.
This comment has been minimized.
It's working fine here now! Both |
Because it was moved out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing it for a couple of days now, and everything has been working great so far. Even wayland with nvidia reverse prime works out-of-the-box! It'd be good if ksysguard
is provided as a package outside of the main plasma5 group. I'm no maintainer, so approving only to provide my experience with the patchset.
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
As ksysguard was replaced, and it was installed by default Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
This broke some of my global shortcut keys. I'm investigating, to see if we can give a smooth user experience with the update. |
This was just for KRunner, and it was due to some stale entries in |
@ttuegel Plasma upgrades often broke my config completely, and if only a few shortcuts are broken then it's fine for me |
Although lately there where no breakages on plasma upgrades, so kudos to the plasma team |
Meanwhile, Plasma 5.22.4 is out. Can we have that release included here? https://kde.org/announcements/plasma/5/5.22.4/ P.S. I'm running 5.22.4 right now, built from this PR + version update. All is good 👍 |
Another week has passed... This isn't exactly encouraging for people considering contributing to the packaging efforts... I'd be fine with either updating this PR to 5.22.4 or just merging it as is and having another PR for that version bump. The diff should be much smaller and faster to review. |
Might be worth pointing to the issue on the discourse to see if that can attract the attention of someone with commit permissions. I guess the list of potential reviewers is just out of date. |
It is a bit discouraging, yeah… :( Off the top of my head, it might be worth posting in one or both of these two:
There's also https://discourse.nixos.org/t/prs-ready-for-review/3032, but I don't think it's the right place since it seems like this has already been reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
Would anyone be interested in applying for commit rights ? If anything doesn't make sense, feel free to ask. |
Should we backport this to release-21.05 ? |
Should we backport this to release-21.05 ?
NACK from here.
Not worth it - let's focus on 21.11
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)