Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atk: support cross-compilation by disabling introspection #123923

Merged
merged 1 commit into from
May 22, 2021
Merged

atk: support cross-compilation by disabling introspection #123923

merged 1 commit into from
May 22, 2021

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 21, 2021

Motivation for this change

Support cross-compilation for atk.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@Mindavi Mindavi added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 21, 2021
@ofborg ofborg bot requested a review from 7c6f434c May 21, 2021 20:39
@ofborg ofborg bot requested a review from 7c6f434c May 21, 2021 21:12
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123923 at 444cec96 run on x86_64-linux 1

697 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
4255 packages skipped due to time constraints:
  • AusweisApp2
  • DisnixWebService
  • MIDIVisualizer
  • OSCAR
  • R
  • SDL_mixer
  • Sylk
  • _1password-gui
  • abcl
  • abiword
  • ...
26 packages built successfully:
  • adoptopenjdk-bin (adoptopenjdk-hotspot-bin-11 ,openjdk11-bootstrap)
  • openjdk16-bootstrap (adoptopenjdk-hotspot-bin-15)
  • openjdk8-bootstrap (adoptopenjdk-hotspot-bin-8)
  • at-spi2-atk
  • atk (gnome.atk ,gnome2.atk)
  • gnome.gnome-desktop (gnome.gnome_desktop)
  • gtk3 (gnome.gtk ,gtk3-x11)
  • gtk2 (gnome2.gtk ,gtk2-x11 ,xfce.gtk)
  • xfce.libglade (gnome2.libglade)
  • gssdp
  • gtk-engine-murrine
  • gupnp
  • gupnp-igd
  • libappindicator (libappindicator-gtk3)
  • libdbusmenu-gtk3
  • libindicator (libindicator-gtk3)
  • lilv
  • lv2
  • openconnect (openconnect_gnutls)
  • saleae-logic
  • spnavcfg
  • sratom
  • stoken
  • sublime
  • tixati
  • usbview

@7c6f434c 7c6f434c merged commit 73ca665 into NixOS:staging May 22, 2021
@Mindavi Mindavi mentioned this pull request May 23, 2021
Closed
@Mindavi Mindavi deleted the atk/cross-compile branch May 23, 2021 12:33
@nagisa
Copy link
Contributor

nagisa commented May 23, 2021

cc @Ericson2314

@Ericson2314
Copy link
Member

Yeah this looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mindavi @r-rmcgibbo @nagisa @Ericson2314 @7c6f434c