-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arc-theme: 20210127 -> 20210412, switch to meson #122086
Conversation
Looks like we have duplicated work #122103 (PRs opened 1h apart) |
Doesn't build currently due to the treewide gnome3 -> gnome rename. |
do I have to pass gnome manually into call-package now or what? A simple rename wasn't enough to fix this package. |
The problem seems to be due to the "-unstable-..." suffix in the gnome-shell version. This commit builds for me: chvp@63a2b6a I haven't tested it yet though. |
I can confirm that the commit that I linked works for me. |
|
||
src = fetchFromGitHub { | ||
owner = "jnsh"; | ||
repo = pname; | ||
rev = version; | ||
sha256 = "sha256-P7YZTD5bAWNWepL7qsZZAMf8ujzNbHOj/SLx8Fw3bi4="; | ||
sha256 = "sha256-BNJirtBtdWsIzQfsJsZzg1zFbJEzZPq1j2qZ+1QjRH8="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sha256 = "sha256-BNJirtBtdWsIzQfsJsZzg1zFbJEzZPq1j2qZ+1QjRH8="; | |
hash = "sha256:BNJirtBtdWsIzQfsJsZzg1zFbJEzZPq1j2qZ+1QjRH8="; |
I think this is the latest style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any doc around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colon is the old Nix style. Dash is the new style, using the https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I would not use the hash
attribute yet, since fetchgit
does not support it.
I also tested this on nixos-unstable and it worked great. Just needed to |
Result of 1 package built:
|
Waiting on either of these to be merged: NixOS/nixpkgs#122086 NixOS/nixpkgs#122103
Motivation for this change
It looks like it needs an update for GNOME 40.
doesn't build yet = draftnow it builds, but I haven't tested it yet.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)