-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: zed-editor #320084
Comments
More about the build error here: #303233 (comment) The Swift package is in |
More information regarding darwin: #317564 (review) |
Building the Swift package will soon become unnecessary, as mentioned in my comment referenced by Gaétan. Unfortunately we'll have to wait for #229210 as Livekit depends on ScreenCaptureKit on macOS. |
This PR adds a Nix/NixOS development-shell (`shell.nix`), which is based on the upstream [nixpkgs](https://github.com/NixOS/nixpkgs/blob/c5d4d458115263ec3ee0efd974e6aeb2f787a0ed/pkgs/by-name/ze/zed-editor/package.nix), as well as its corresponding `flake.nix` file. To use it, run either the `nix-shell` command (uses the `shell.nix` file), or the newer but experimental `nix develop` command (uses `flake.nix`) ~~This has not been tested on macOS, tho preliminary code is there to try and support it, feel free to report any issues.~~ Zed unfortunately doesn't build on nix-darwin (see NixOS/nixpkgs#320084), so this PR doesn't aim to add darwin support. --- Release Notes: - N/A --------- Signed-off-by: xtrm <oss@xtrm.me> Co-authored-by: Niklas Korz <niklas@niklaskorz.de>
Looks like #326406 merged early support for apple_sdks 12.3 -- would that resolve the blocker you mentioned @niklaskorz? |
Draft PR is available at #329653 but is blocked until zed-industries/zed#13343 is merged and released. As the draft is based on that PR branch, it however already builds and runs:
Edit: now correctly produces an app bundle, and the CLI also works now |
#329653 is now ready for review, fixing the latest Zed release on macOS. Livekit (and thus collaboration features) remains disabled on both macOS and Linux until zed-industries/zed#13343 is released. |
Steps To Reproduce
Zed-editor fails to build for MaxOS Intel using
NIXPKGS_ALLOW_BROKEN=1 nix-shell -p zed-editor -I nixpkgs=channel:nixos-unstable
Build log
Additional context
Add any other context about the problem here.
Notify maintainers
@GaetanLepage
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: