Skip to content

Commit

Permalink
build-lua-package: dont patchShebangs folder
Browse files Browse the repository at this point in the history 
It can be source of trouble for some read-only folders (libluv for
instance) and slow down install.
  • Loading branch information
@teto
teto committed Feb 25, 2020
1 parent 3989298 commit 7aee5b8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkgs/development/interpreters/lua-5/build-lua-package.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ builtins.removeAttrs attrs ["disabled" "checkInputs" "externalDeps"] // {
LUAROCKS="$LUAROCKS --verbose"
fi
patchShebangs .
runHook postBuild
'';

Expand Down

6 comments on commit 7aee5b8

@vcunat
Copy link
Member

@vcunat vcunat commented on 7aee5b8 Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a regression: #81206

@teto
Copy link
Member Author

@teto teto commented on 7aee5b8 Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a regression: #81206

isnt thqt the same as #80704 rqther ? i dont see the shebang influence

@mweinelt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did bisect #81206 to this commit.

@mweinelt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, reverting this commit doesn't fix it for me though.

@teto
Copy link
Member Author

@teto teto commented on 7aee5b8 Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to do with this commit; neovim is broken on master; we are working on a fix. Meanwhile revert the latest luarocks bump and it will work again.

@vcunat
Copy link
Member

@vcunat vcunat commented on 7aee5b8 Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, on this commit luajitPackages.luv.libluv fails and on the parent commit it succeeds. That's how I bisected to this place. I haven't tried to understand it (yet).

Please sign in to comment.