Make recursive-nix work even when not privileged #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-as
force-pushed
the
recursive-nix-fix
branch
from
a7ac388
to
4e0f851
Compare
|
Note: The |
Mindavi
reviewed
Oct 10, 2021
4 tasks
|
bump |
Before this, `setns` would fail when switching to the mount namespace, since we did not have the privileges to do so when not root. Closes NixOS#5360
L-as
force-pushed
the
recursive-nix-fix
branch
from
4e0f851
to
8388d2c
Compare
|
@edolstra any questions with this one? I thought it was a pretty straight-forward fix. |
|
I think this patch is still needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this,
setnswould fail when switching to the mount namespace,since we did not have the privileges to do so when not root.
Closes #5360