Start getting all shell scripts passing shellcheck #10787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
contributor-experience
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
shellcheck-tests
branch
from
f5b9c36
to
1dfd649
Compare
Like with the formatter, we are blacklisting most files by default. Do a few files to get us started, and get a sense of what this looks like.
Ericson2314
force-pushed
the
shellcheck-tests
branch
from
1dfd649
to
567265a
Compare
roberth
approved these changes
May 28, 2024
There was a problem hiding this comment.
This would be the best time to start to use per-hook excludes.
There was a problem hiding this comment.
Agreed. I'll convert it next.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
May 28, 2024
As suggested by Robert in NixOS#10787 (comment)
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Like with the formatter, we are blacklisting most files by default.
Context
Do a few files to get us started, and get a sense of what this looks like.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.