C API: nix_get_string now accepts a callback to return the value #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
approved these changes
Apr 17, 2024
Comment on lines
+49
to
+52
| void my_get_string_cb(const char * start, unsigned int n, char ** user_data) | ||
| { | ||
| *user_data = strdup(start); | ||
| } |
There was a problem hiding this comment.
We could provide this function as part of the C interface. It's an obvious choice for C code, and I think most FFIs have something for dealing with malloced memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As suggested by @roberth in #8699 (comment),
use the callback approach to simplify GC and avoid breaking changes if we change the internal representation of strings.
Context
Stabilize the C interface introduced in #8699
Milestone: https://github.com/NixOS/nix/milestone/52
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.