Apply suggestions from code review

Thanks! Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
NixOS · Jan 22, 2021 · 7eab7b9 · 7eab7b9
1 parent 7af7434
commit 7eab7b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/build-remote/build-remote.cc b/src/build-remote/build-remote.cc
@@ -75,11 +75,11 @@ static int main_build_remote(int argc, char * * argv)
 
         /* It would be more appropriate to use $XDG_RUNTIME_DIR, since
            that gets cleared on reboot, but it wouldn't work on macOS. */
-        currentLoad = "/current-load";
+        auto currentLoadName = "/current-load";
         if (auto localStore = store.dynamic_pointer_cast<LocalFSStore>())
-            currentLoad = std::string { localStore->stateDir } + currentLoad;
+            currentLoad = std::string { localStore->stateDir } + currentLoadName;
         else
-            currentLoad = settings.nixStateDir + currentLoad;
+            currentLoad = settings.nixStateDir + currentLoadName;
 
         std::shared_ptr<Store> sshStore;
         AutoCloseFD bestSlotLock;

diff --git a/src/libstore/build/derivation-goal.cc b/src/libstore/build/derivation-goal.cc
@@ -3291,7 +3291,7 @@ void DerivationGoal::registerOutputs()
 
         auto localStoreP = dynamic_cast<LocalStore *>(&worker.store);
         if (!localStoreP)
-            Unsupported("Can only register outputs with local store");
+            throw Unsupported("can only register outputs with local store");
         auto & localStore = *localStoreP;
 
         if (buildMode == bmCheck) {
@@ -3426,7 +3426,7 @@ void DerivationGoal::registerOutputs()
     {
         auto localStoreP = dynamic_cast<LocalStore *>(&worker.store);
         if (!localStoreP)
-            Unsupported("Can only register outputs with local store");
+            throw Unsupported("can only register outputs with local store");
         auto & localStore = *localStoreP;
 
         ValidPathInfos infos2;