Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two misc ideas for Nix itself #13

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Conversation

Ericson2314
Copy link
Member

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a descriptions in a similar manner to #14 and summarize the current state of the issues?

@Ericson2314
Copy link
Member Author

OK added descriptions

ideas/2024.md Outdated Show resolved Hide resolved
ideas/2024.md Outdated Show resolved Hide resolved
@Janik-Haag
Copy link
Member

Should I still wait with merging until roberth gave it a look?

@Ericson2314
Copy link
Member Author

I'll try to get another Nix team person to weigh in

@roberth
Copy link
Member

roberth commented Feb 6, 2024

another Nix team person

I kinda already started typing. Did you mean someone other me? That would be good.
Nonetheless here are my thoughts:

CLI stabilization

Might CLI stabilization be a better choice? It'd be good to finish ongoing projects first, but then we might underestimate the effect on consistency from having done CLI review together. We have guidelines, but those are probably not sufficient. I wonder how much can be done without requiring an equal amount of input from team members.

Thoughts about changing the data model

We should organize those issues into an epic or tracking issue, along with

and (just for context) perhaps even

Our ecosystem-wide data model is slightly off in many places. I think this strategy is generally applicable

  • refactor internal Nix data structures (without change in behavior)
  • expose simplified logic based on the improved internal data model, masked by experimental feature

I'm conflicted about the size and scope of such feature flags. We have multiple fixes, and by balling them together we may avoid some unnecessary compatibility logic, which we'd have to support indefinitely. But also it risks creating a dragged out change process as with Flakes.

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable for beginners with some C++ knowledge.

ideas/2024.md Outdated Show resolved Hide resolved
@Ericson2314
Copy link
Member Author

Ericson2314 commented Feb 6, 2024

@roberth I meant you, or baring that, someone else. I.e. not me alone. Not excluding you :).

Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@Ericson2314
Copy link
Member Author

Yeah re @roberth the ideal thing would be some epics, and the GSOC person can simple start on what bite-sized pieces are not done by the time summer rolls around, but sadly I think grant processes punish agility like that.

@Janik-Haag
Copy link
Member

Is there anything missing here or can I go ahead and merge this?

@Ericson2314
Copy link
Member Author

@Janik-Haag Yeah it can be merged. @roberth and I agree the stuff he wrote is not for changing it, but for following this up with more ideas if we like.

@Janik-Haag Janik-Haag merged commit c2bc97a into NixOS:main Feb 12, 2024
@Ericson2314 Ericson2314 deleted the misc-nix branch February 12, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants