Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli break on Extra Verification for french org #317

Closed
matthieugauthier opened this issue Aug 27, 2021 · 0 comments · Fixed by #341
Closed

Cli break on Extra Verification for french org #317

matthieugauthier opened this issue Aug 27, 2021 · 0 comments · Fixed by #341

Comments

@matthieugauthier
Copy link
Contributor

matthieugauthier commented Aug 27, 2021

Expected Behavior

When authenticating it succeed and don't crash :)

Current Behavior

When authenticating it crash.

👾 matthieugauthier@MacBook-Pro-de-Matthieu ➜ connect-aws gimme-aws-creds

Using password from keyring for mylogin
Traceback (most recent call last):
File "/usr/local/bin/gimme-aws-creds", line 17, in
GimmeAWSCreds().run()
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 469, in run
self._run()
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 802, in _run
for data in self.iter_selected_aws_credentials():
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 773, in iter_selected_aws_credentials
for role in self.aws_selected_roles:
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 672, in aws_selected_roles
selected_roles = self._get_selected_roles(self.requested_roles, self.aws_roles)
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 663, in aws_roles
self.saml_data['SAMLResponse'],
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/main.py", line 654, in saml_data
self._cache['saml_data'] = saml_data = self.okta.get_saml_response(self.aws_app['links']['appLink'])
File "/usr/local/lib/python3.9/site-packages/gimme_aws_creds/okta.py", line 725, in get_saml_response
raise RuntimeError(saml_error)
RuntimeError: Did not receive SAML Response after successful authentication [https://myorg.okta-emea.com/home/myapp]

Possible Solution

Match french string too.

Steps to Reproduce (for bugs)

  1. Get a french OKTA org
  2. Run gimme-aws-creds with MFA

Context

Without fix, it break gimme to works.
Actually we patch in fork, but it break requirements.txt when using it in our custom AWS SSM Cli.
So its painfull for french to get a clean install.

Your Environment

  • App Version used: 2.4.3
  • Environment name and version: python3.9
  • Operating System and version: Mac 11.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant