Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings (@types) #8

Open
ruipimentel opened this issue Jul 24, 2018 · 5 comments · May be fixed by #29
Open

Typings (@types) #8

ruipimentel opened this issue Jul 24, 2018 · 5 comments · May be fixed by #29

Comments

@ruipimentel
Copy link

Hi! First of all, thank you for the amazing lib! It's the perfect companion for D3.

I've been using the latter in an Angular 6 project and it has its Typings available at:

npm install --save-dev @types/d3

Now, it's time to turn my charts into 3D. 📈 Is there a way to obtain Typings for D3-3D also?

Thanks in advance!

@MariDani
Copy link

@ruipimentel Hi, did you eventually get the types for typescript?

@ruipimentel
Copy link
Author

@MariDani Hi!

Unfortunately I did not. Had to take a break at that project, even though I still search a solution for it from time to time.

If you ever get to find the types, please let people know about it here, ok? :D

Thanks in advance!

@ruipimentel
Copy link
Author

Even though I still haven't found @types for D3-3D, at least I found a way to import it inside of an Angular 6 project without getting errors.

import { _3d } from 'd3-3d';

Then, instead of using it as shown on the repo's homepage (d3._3d()), just proceed to call _3d() directly.

@aminya aminya linked a pull request Jun 28, 2024 that will close this issue
@aminya
Copy link

aminya commented Jun 28, 2024

I created a pull request that fixes the issue
#29

@aminya
Copy link

aminya commented Jul 18, 2024

I upstreamed my pull request to @types. The types is available under @types/d3-3d.

https://www.npmjs.com/package/@types/d3-3d

DefinitelyTyped/DefinitelyTyped#70087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants