01_litigations_lead.Rmd Review

[romartinez-nycc]

Some of these Nick commented on as well, sorry for the duplication!

• This works for me source("../code/utils/00_load_dependencies.R") instead of

  lead_hearing/code/01_litigations_lead.Rmd

  Lines 12 to 13 in d6e6b34

  	setwd("/Users/rhirota/Documents/GitHub/lead_hearing")
  	source("code/utils/00_load_dependencies.R")

• Option to use vroom(). Vroom library has faster reads than fread, if the data is really large, I recommend using vroom & then converting it into datatable.

  lead_hearing/code/01_litigations_lead.Rmd

  Line 21 in d6e6b34

  litigations <-fread("https://data.cityofnewyork.us/resource/59kj-x8nc.csv?$limit=99999999999")

• Please comment the code here for non-datatable folks

  lead_hearing/code/01_litigations_lead.Rmd

  Lines 22 to 31 in d6e6b34

  	litigations[, yr := year(caseopendate)]
  	litigations <- litigations[, yr := year(caseopendate)]
  	litigations <- litigations[litigations$yr>2005,] # not complete data
  	```
  	```{r}
  	# ---- CLEAN DATA ----
  	lead_litigations <- unique(litigations[grep("lead", casetype, ignore.case = TRUE), ])
  	lead_litigations <- unique(lead_litigations[!grep("non-lead", casetype, ignore.case = TRUE), ])
  	lead_litigations[, lit_bbl := length(unique(litigationid)), by = .(bbl)]

• I added dplyr as a required library in load_dependcies to run the following:

  lead_hearing/code/01_litigations_lead.Rmd

  Lines 37 to 40 in d6e6b34

  	temp <- lead_litigations %>% group_by(yr) %>% summarise(count_lead=n())
  	temp2 <- litigations %>% group_by(yr) %>% summarise(count_total=n())
  	temp <- temp2 %>% full_join(y = temp, by = 'yr')
  	temp <- temp[temp$yr <= 2023 & !is.na(temp$yr) & !is.na(temp$count_lead), ] # not sure why NA/2030 is in there... data entry error?

• I added ggplot to run the plots below,

  lead_hearing/code/01_litigations_lead.Rmd

  Line 42 in d6e6b34

  # ---- plot number of lead litigations by year

  I recommend breaking out each plot as its own code chunk and spacing out the lines to increase readability.
• Lets move this to the bottom or remove (but please save it somewhere else for future work!)
  

  lead_hearing/code/01_litigations_lead.Rmd

  Line 60 in d6e6b34

  Possible interest: Open judgement (yes) or harassment found or penalty assigned